Display prompt for enabling GPS #252

bernamaxim · 2017-02-08T20:40:40Z

Display prompt for enabling GPS, when it disable. Because when forget to enable Location service, Traccar client cannot send location at all.

tananaev

Added some comments.

tananaev · 2017-02-08T21:04:00Z

app/src/main/java/org/traccar/client/MainActivity.java

+    {
+        final AlertDialog.Builder builder = new AlertDialog.Builder(activity);
+        final String action = Settings.ACTION_LOCATION_SOURCE_SETTINGS;
+        final String message = "Enable location service to find current location. Click OK to go to.";


Please don't use hardcoded strings.

tananaev · 2017-02-08T21:04:23Z

app/src/main/java/org/traccar/client/MainActivity.java

@@ -230,6 +233,25 @@ private void initPreferences() {
        findPreference(KEY_DEVICE).setSummary(sharedPreferences.getString(KEY_DEVICE, null));
    }

+    private void displayPromptForEnablingGPS(


GPS should be camel-cased.

tananaev · 2017-02-08T21:04:42Z

app/src/main/java/org/traccar/client/MainActivity.java

+            final Activity activity)
+    {
+        final AlertDialog.Builder builder = new AlertDialog.Builder(activity);
+        final String action = Settings.ACTION_LOCATION_SOURCE_SETTINGS;


Why do we need a variable for this?

tananaev · 2017-02-08T21:05:44Z

app/src/main/java/org/traccar/client/MainActivity.java

@@ -255,6 +277,10 @@ private void startTrackingService(boolean checkPermission, boolean permission) {
            startService(new Intent(this, TrackingService.class));
            alarmManager.setInexactRepeating(AlarmManager.ELAPSED_REALTIME_WAKEUP,
                    15000, 15000, alarmIntent);
+            String locationProviders = Settings.Secure.getString(getContentResolver(), Settings.Secure.LOCATION_PROVIDERS_ALLOWED);
+            if (locationProviders == null || locationProviders.equals("")) {


Use TextUtils.isEmpty(...) instead.

tananaev · 2017-02-08T21:06:46Z

app/src/main/java/org/traccar/client/MainActivity.java

@@ -255,6 +277,10 @@ private void startTrackingService(boolean checkPermission, boolean permission) {
            startService(new Intent(this, TrackingService.class));
            alarmManager.setInexactRepeating(AlarmManager.ELAPSED_REALTIME_WAKEUP,
                    15000, 15000, alarmIntent);
+            String locationProviders = Settings.Secure.getString(getContentResolver(), Settings.Secure.LOCATION_PROVIDERS_ALLOWED);
+            if (locationProviders == null || locationProviders.equals("")) {
+                displayPromptForEnablingGPS(this);


Why is it called "GPS" when you check for all providers?

tananaev · 2017-02-08T21:07:27Z

app/src/main/java/org/traccar/client/MainActivity.java

@@ -255,6 +277,10 @@ private void startTrackingService(boolean checkPermission, boolean permission) {
            startService(new Intent(this, TrackingService.class));


Should we wait till user enables providers before starting the service?

Sure, because if user not enable providers, it will be useless. Traccar-client cannot update location and send it.

You said yes, but you haven't fixed it.

I'm sorry, I'm still trying but have not been successful. I try to use AsyncTask (https://developer.android.com/reference/android/os/AsyncTask.html)

…gs, use TextUtils to check Location

tananaev · 2017-02-13T01:50:06Z

app/src/main/java/org/traccar/client/MainActivity.java

+    {
+        final AlertDialog.Builder builder = new AlertDialog.Builder(activity);
+        builder.setMessage(R.string.prompt_location_service)
+                .setPositiveButton("OK",


Still hardcoded string here.

tananaev · 2017-02-13T01:53:11Z

app/src/main/res/values/strings.xml

@@ -44,4 +44,5 @@
  <string name="status_connectivity_change">Connectivity change</string>
  <string name="hidden_app_name">Device Settings</string>
  <string name="hidden_alert">The app has been hidden. To open it again please dial 8722227 (TRACCAR).</string>
+  <string name="prompt_location_service">Enable location service to find current location. Click OK to go to.</string>


Please use some better wording. Something like:

Please enable location services. Click OK to open settings screen.

tananaev · 2017-02-13T01:53:35Z

app/src/main/java/org/traccar/client/MainActivity.java

@@ -255,6 +277,10 @@ private void startTrackingService(boolean checkPermission, boolean permission) {
            startService(new Intent(this, TrackingService.class));


You said yes, but you haven't fixed it.

vliparsov · 2017-08-27T20:30:08Z

😁

Anton-V-K · 2018-01-01T15:30:25Z

Are the code conflicts resolved already? Is this feature ready for releasing?

tananaev · 2018-01-01T20:31:31Z

As you can see, there were no commits after my review, so nothing is solved.

Display prompt for enabling GPS

0954b9d

tananaev reviewed Feb 8, 2017

View reviewed changes

Fix camel-cased, remove uneccessary variable, not use hardcode settin…

9b0a7d2

…gs, use TextUtils to check Location

tananaev reviewed Feb 13, 2017

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Display prompt for enabling GPS #252

Display prompt for enabling GPS #252

bernamaxim commented Feb 8, 2017 •

edited

Loading

tananaev left a comment

tananaev Feb 8, 2017

tananaev Feb 8, 2017

tananaev Feb 8, 2017

tananaev Feb 8, 2017

tananaev Feb 8, 2017

tananaev Feb 8, 2017

bernamaxim Feb 8, 2017

tananaev Feb 13, 2017

bernamaxim Feb 13, 2017

tananaev Feb 13, 2017

tananaev Feb 13, 2017

tananaev Feb 13, 2017

vliparsov commented Aug 27, 2017

Anton-V-K commented Jan 1, 2018

tananaev commented Jan 1, 2018 •

edited

Loading

		@@ -255,6 +277,10 @@ private void startTrackingService(boolean checkPermission, boolean permission) {
		startService(new Intent(this, TrackingService.class));

Display prompt for enabling GPS #252

Are you sure you want to change the base?

Display prompt for enabling GPS #252

Conversation

bernamaxim commented Feb 8, 2017 • edited Loading

tananaev left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vliparsov commented Aug 27, 2017

Anton-V-K commented Jan 1, 2018

tananaev commented Jan 1, 2018 • edited Loading

bernamaxim commented Feb 8, 2017 •

edited

Loading

tananaev commented Jan 1, 2018 •

edited

Loading